Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Clickhouse support #53

Closed
r-zenine opened this issue Mar 21, 2021 · 5 comments · Fixed by #133
Closed

Add Clickhouse support #53

r-zenine opened this issue Mar 21, 2021 · 5 comments · Fixed by #133

Comments

@r-zenine
Copy link

Hello,

First of all , thanks for the project, it looks great !

I would like to know if you would welcome clickhouse support in sqls.
I could look at the code and see how I could make that happen. In addition, given that clickhouse is open source, we could integrate CI tests in your current workflow.

Would you welcome such PR ? If so, could you point me to the right direction ?

I was planing to use the official go driver for clickhouse

Thanks
Again, great work already !
Thank you for taking the time to build this LSP server.
@PhilipMok-cc
Copy link
Contributor

I added oracle support PR, recently. I think it is the minimal change of adding a new driver. Please talk a look

@r-zenine
Copy link
Author

r-zenine commented Jan 5, 2022 •
edited
Loading

Hello @PhilipMok-cc ,
Thank you for your answer !

Are you referring to this PR #78 ?
I'll take a look next week-end to add the support of click house.

@PhilipMok-cc
Copy link
Contributor

Yes, but there are some issue.

  1. Testing required a service container to support.
    Other than that the test routine is covered all the issue I have met during testing and I think it is generic to all kind of DB.

@franchb
Copy link

franchb commented Jan 26, 2022

Hello!

Just mind that v2 version is on the road https://github.com/ClickHouse/clickhouse-go/releases/tag/v2.0.0-beta.5

Maintainers have already switched their production servers to v2.

patrickpichler added a commit to patrickpichler/sqls that referenced this issue Feb 2, 2024
@patrickpichler
Add clickhouse database support
4a8c03c 
This adds initial support for the clickhouse database system. Keywords
are currently based upon postgres, as the clickhouse docs do not provide
a good overview of all allowed keywords.

fix sqls-server#53
@patrickpichler patrickpichler mentioned this issue Feb 2, 2024
Merged
@patrickpichler
Copy link
Contributor

Hey :)

I've created a PR to add clickhouse database support. I hope this is still wanted!

(see #133)

patrickpichler added a commit to patrickpichler/sqls that referenced this issue Feb 2, 2024
@patrickpichler
Add clickhouse database support
08d46fc 
This adds initial support for the clickhouse database system. Keywords
are currently based upon postgres, as the clickhouse docs do not provide
a good overview of all allowed keywords.

fix sqls-server#53
patrickpichler added a commit to patrickpichler/sqls that referenced this issue Feb 5, 2024
@patrickpichler
Add clickhouse database support
45b5eaa 
This adds initial support for the clickhouse database system. Keywords
are currently based upon postgres, as the clickhouse docs do not provide
a good overview of all allowed keywords.

fix sqls-server#53
patrickpichler added a commit to patrickpichler/sqls that referenced this issue Feb 5, 2024
@patrickpichler
Add clickhouse database support
fc96163 
This adds initial support for the clickhouse database system. Keywords
are currently based upon postgres, as the clickhouse docs do not provide
a good overview of all allowed keywords.

fix sqls-server#53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add clickhouse database support patrickpichler/sqls
4 participants
@patrickpichler @franchb @r-zenine @PhilipMok-cc