Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in table component, naming a column "progress" lead to weird layout #830

Open
setop opened this issue Feb 26, 2025 · 2 comments
Open

in table component, naming a column "progress" lead to weird layout #830

setop opened this issue Feb 26, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@setop
Copy link
Contributor

setop commented Feb 26, 2025

Introduction

In table component, naming a column "progress" lead to weird layout of the column.
Any other variation of the name and type does not produce that.

To Reproduce

select 'table' as component;
select 
  'foo' as name
  , 100*0.1 as progress;               ---    <- note the name of the column

Actual behavior

column values are displaced.

Screenshots

Image

Expected behavior

column values are aligned with the rest of the line.

select 'table' as component;
select 
  'foo' as name
  , 100*0.1 as progres_;               ---    <- note the name of the column

Image

Version information

  • OS:linux
  • Database : SQLite
  • SQLPage Version : 0.33.0

Additional context

Add any other context about the problem here.

@setop setop added the bug Something isn't working label Feb 26, 2025
@lovasoa
Copy link
Collaborator

lovasoa commented Feb 26, 2025

Indeed, that is an issue. We currently add the name of the column as a css class to the column, for easier custom styling, but this can conflict with existing classes. We should add a prefix to the class name added to the column, but that will break existing apps that rely on the current class names.

@setop
Copy link
Contributor Author

setop commented Feb 26, 2025

exactly, the class "progress" has a property "height" that seems to be the cause:

Image

I'll stay with a typo for the moment. "progres" is fine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants