Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from validate icon #821

Open
setop opened this issue Feb 21, 2025 · 2 comments
Open

from validate icon #821

setop opened this issue Feb 21, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@setop
Copy link
Contributor

setop commented Feb 21, 2025

What are you building with SQLPage ?

a movie gallery

What is your problem ?

The "button" component has an option to set an icon. However the "form" component, according to the documentation, does not have this option for the validate button, only text and color.

What are you currently doing ?

I go without any icon on the validate button of the form 😞.

Describe the solution you'd like

In the Top-level parameters of the form component, have an option called "validate_icon", not required, of type "ICON", with a description "Name of an icon to be displayed on the left side of the validation button of the form".

When used, this option will display an icon, defined by its name, on the left of the validation button of the form component being defined.

Describe alternatives you've considered

N/A

Additional context

Wonderful tool, BTW. I so much like not to have to touch any JS nor CSS.

@setop setop added the enhancement New feature or request label Feb 21, 2025
@lovasoa
Copy link
Collaborator

lovasoa commented Feb 21, 2025

I agree that would be useful ! Would you be interested in opening a small Pull Request targetting https://github.com/sqlpage/SQLPage/blob/main/sqlpage/templates/form.handlebars ?

see https://github.com/sqlpage/SQLPage/blob/main/CONTRIBUTING.md

@setop
Copy link
Contributor Author

setop commented Feb 21, 2025

Sure, I'll have a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants