-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux binary of v0.33.0 panicks #814
Comments
That's bad ! I cannot reproduce it. Can you run with |
Output of
|
It does contain the actual value returned by A return value of 2 (ENOENT) is strange and really unexpected. In the meantime, here is a build without the bug inducing dependency: sqlpage.bin.gz. Can you confirm it fixes the issue for you ? But I'd like to get to the bottom of this. |
This is on a really restricted linux system with heavily reduced access to the system environment and quite low memory/cpu resources (basically it's managed hosting with ssh access as a goodie). I wouldn't have posted a bug if it didn't work before as my expectancy for this to work there was originally quite low. To my surprise, it worked a lot better than expected, at least enough to experiment. For production, I'd use a different system with more resources and fewer restrictions. :) |
Do you have an idea how we could reproduce this restricted environment locally ? That would help ! stacker is a popular crate in the rust ecosystem, with 17M downloads, so the issue probably affects much more than just sqlpage. Even on a restricted environment, crashing with a cryptic error message is not a desirable behavior. |
Unfortunately, I don't know how to emulate this specific environment and I'm not really linux savvy. The hoster is netcup and the plan is Webhosting 2000 (https://www.netcup.com/en/hosting). Unfortunately, the fixed binary you posted doesn't work because it doesn't seem to be statically linked to glibc:
|
Ok, the ENOENT (2) error code and your message put me on the right path, I can reproduce it now ! ❯ sudo mount -t tmpfs none /proc
❯ ./sqlpage.bin
thread 'main' panicked at /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/stacker-0.1.18/src/lib.rs:418:13:
assertion `left == right` failed
left: 2
right: 0
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Aborted (core dumped) In the same environment, sqlpage without the stacker dependency works fine. I reported the issue to stacker, so that they can hopefully fix it: rust-lang/stacker#115 In the meantime, you can use the following statically linked binary: sqlpage.bin.gz |
Thank you! This binary works fine. :) |
* update deps * Disable stack growing in sqlparser Fixes #814 ?
* improve error handling see #115 See sqlpage/SQLPage#814 * improve error message in destroy_pthread_attr * remove code duplication * cleanup code and add comments * Make error handling code easier to read * update formatting https://github.com/rust-lang/stacker/pull/116/files#r1961535064 * put the beautiful unicode apostrophe back https://github.com/rust-lang/stacker/pull/116/files#r1961536979 * use one file per guess_os_stack_limit implementation * fix error handling on openbsd too * beautiful unicode apostrophe * format * fix windows build * remove unused unsafe * fix error handling on windows VirtualQuery is a faillible function that was treated as infaillible https://learn.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-virtualquery * SetThreadStackGuarantee can also error on windows * simplify pthread error handling
Introduction
I just updated the provided linux binary (sqlpage github repository) from v0.32.1 to v0.33.0 and since then I can't run sqlpage anymore as it breaks with following error message:
To Reproduce
Run sqlpage binary without any additional flags.
Linux a2f8a 5.10.0-32-amd64 #1 SMP Debian 5.10.223-1 (2024-08-10) x86_64 GNU/Linux
The text was updated successfully, but these errors were encountered: