Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hql-Queries using CEILING and LN. #3711

Closed
wants to merge 2 commits into from

Conversation

coderesting
Copy link
Contributor

The Hibernate functions ceiling and ln are currently breaking the spring-data Query validation.

Problem: CEILING and LN were defined as reserved identifiers in the hql grammar file but never used.
Solution: This Pull Request adds CEILING and LN to the List of reserved words for use as a function name or identifier.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@pivotal-cla
Copy link

@coderesting Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 11, 2024
@mp911de mp911de self-assigned this Dec 11, 2024
@pivotal-cla
Copy link

@coderesting Thank you for signing the Contributor License Agreement!

@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 11, 2024
@mp911de mp911de added this to the 3.4.1 (2024.1.1) milestone Dec 11, 2024
@mp911de
Copy link
Member

mp911de commented Dec 11, 2024

Thanks a lot. We're generally limited towards function names that we declare while Hibernate accepts unknown function names. That requires a slightly different approach to allow these. I'll take care of this during the merge.

mp911de pushed a commit that referenced this pull request Dec 11, 2024
mp911de added a commit that referenced this pull request Dec 11, 2024
Align HQL parsing with Hibernate to accept generic function names. Also, align literals, add missing expression grammar for ID, NATURALID, VERSION, TYPE, FK and remove parser rules interfering with undesired parsing results. Add missing literals.

See #3711
@mp911de mp911de closed this in 2eaa6d5 Dec 11, 2024
mp911de added a commit that referenced this pull request Dec 11, 2024
Align HQL parsing with Hibernate to accept generic function names. Also, align literals, add missing expression grammar for ID, NATURALID, VERSION, TYPE, FK and remove parser rules interfering with undesired parsing results. Add missing literals.

See #3711
@mp911de
Copy link
Member

mp911de commented Dec 11, 2024

Thank you for your contribution. That's merged, polished, and backported now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants