Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use version-agnostic Hibernate presence check in QueryEnhancerFactory #3212

Closed
wants to merge 2 commits into from

Conversation

AurMario
Copy link

Hibernate 5.6 supports JPA 3.0, and should be usable with Spring Data JPA 3.1.x. Currently, only Hibernate 6 is detected and allows for the HQL Parser usage. This PR consists in enabling the HQL Parser in the case of Hibernate 5 too.

  • [x ] You have read the Spring Data contribution guidelines.
  • [x ] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • [x ] You submit test cases (unit or integration tests) that back your changes.
  • [x ] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@pivotal-cla
Copy link

@AurMario Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@AurMario Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 26, 2023
@mp911de mp911de self-assigned this Nov 2, 2023
@mp911de
Copy link
Member

mp911de commented Nov 2, 2023

After upgrading to a new major version, we typically require the new baseline. We can support Hibernate 5.6 on a best-effort basis without actually guaranteeing that everything is working, as our tests use the JPA 3.1 baseline.

We're fine with this one change, however, we do not intent to put in more effort into downgrading compatibility.

@mp911de mp911de added this to the 3.1.6 (2023.0.6) milestone Nov 2, 2023
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 2, 2023
@mp911de mp911de changed the title Detect Hibernate 5 for HQL Parser support Use HQL parser when Hibernate 5 is on the class path Nov 2, 2023
@mp911de mp911de changed the title Use HQL parser when Hibernate 5 is on the class path Use HQL parser when Hibernate 5 is on the classpath Nov 2, 2023
@mp911de mp911de changed the title Use HQL parser when Hibernate 5 is on the classpath Use version-agnostic Hibernate presence check in QueryEnhancerFactory Nov 2, 2023
@mp911de
Copy link
Member

mp911de commented Nov 2, 2023

We've rewritten the presence detection for Spring Data JPA 3.2 already to a version-agnostic form and I polished up the pull request in the same direction. Can you also test whether the current 3.2 snapshots work with your Hibernate 5.6 arrangement?

@mp911de mp911de closed this Nov 2, 2023
mp911de pushed a commit that referenced this pull request Nov 2, 2023
mp911de added a commit that referenced this pull request Nov 2, 2023
Use version-agnostic Hibernate presence check.

See #3212
@mp911de
Copy link
Member

mp911de commented Nov 2, 2023

Thank you for your contribution. That's merged and polished now into the 3.1.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants