Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise DeclaredQuery count query derivation #3156

Closed
mp911de opened this issue Sep 12, 2023 · 1 comment
Closed

Revise DeclaredQuery count query derivation #3156

mp911de opened this issue Sep 12, 2023 · 1 comment
Labels
status: superseded An issue that has been superseded by another

Comments

@mp911de
Copy link
Member

mp911de commented Sep 12, 2023 •
edited
Loading

DeclaredQuery.deriveCountQuery(@Nullable String countQuery, @Nullable String countQueryProjection) is a strange way encapsulating a conditional block. Also, if the DeclaredQuery is already a count query: What is that method supposed to do?
@mp911de mp911de added the type: task A general task label Sep 12, 2023
@mp911de mp911de added status: superseded An issue that has been superseded by another and removed type: task A general task labels Jan 31, 2025
@mp911de
Copy link
Member Author

mp911de commented Jan 31, 2025

Superseded by #3527 and #2989 that also require a type split.

@mp911de mp911de closed this as completed Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mp911de