Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State is often mistranslated as state of country #427

Open
Alshurafa opened this issue Jul 7, 2014 · 14 comments
Open

State is often mistranslated as state of country #427

Alshurafa opened this issue Jul 7, 2014 · 14 comments

Comments

@Alshurafa
Copy link

I have noticed that both in the localeapp website and here in the config/locale that state is often mistranslated. This is due to the use of the word state as of a country sometimes and as a condition like in order state, spree/inventory_unit, payment state, . Is there a way to avoid confusion? Perhaps by changing state to something like 'status', 'standing', or 'condition' or by making state alone refer to state of country Otherwise its something like 'inventory unit state' just like payment state and shipping state.

@radar
Copy link
Contributor

radar commented Jul 11, 2014

Hello Alshurafa,

Can you point us to where these thing are mistranslated? It should be pretty clear in the translations file that it's "inventory unit state" vs "a country's state" based on the key within the translation file.

I'd really like to know where people are being confused about that and then we can go about removing that confusion.

On Mon, Jul 7, 2014 at 12:08 PM, Alshurafa [email protected]
wrote:

I have noticed that both in the localeapp website and here in the config/locale that state is often mistranslated. This is due to the use of the word state as of a country sometimes and as a condition like in order state, spree/inventory_unit, payment state, . Is there a way to avoid confusion? Perhaps by changing state to something like 'standing' or 'condition' or by making state alone refer to state of country Otherwise its something like 'inventory unit state' just like payment state and shipping state.

Reply to this email directly or view it on GitHub:
#427

@Alshurafa
Copy link
Author

The project is filled with them. One of the reasons I am redoing the Arabic translation from scratch is because many translations need deployment to get the accurate meaning. It is sometimes obvious but not always. For example, the last "state" around line 1000 has no way of telling the intended translation but I think it is state(province) since status is a couple of lines away from it.

Examples from ca.yml (Estat = status / Província = state or province)
spree/inventory_unit:
state: Província
spree/state:
one: Estat
other: Estats
[Translation source: Self]

Examples from cs.yml (Stav = status / Země = state or province)
spree/inventory_unit:
state: Země
state: Stav (line 1006)
[Translation source: a friend]

In fact inventory unit state is often translated as state or province
[da.yml]
spree/inventory_unit:
state: Delstat
[de.yml]
spree/inventory_unit:
state: Bundesland
[es-CL.yml]
spree/inventory_unit:
state: Comuna
[fr.yml]
spree/inventory_unit:
state: استان
[Translation source: Google Translate]

I also double checked by going over the translation of "status" and "address state" translations which are often right and compared them to with spree/inventory_unit state All 7 files that I picked include spree/inventory_unit state as a province not status.

I barely finished translating %30 of the required strings. If you want, I will keep track of ambiguous sentences provide you with a complete list of them.

@JDutil
Copy link
Member

JDutil commented Oct 30, 2014

I think it could clear up confusion if we changes state to status, but that would also require changing core & en translations. Perhaps this could be done during the spree 3 update, but would want to see what people think.

@JDutil JDutil added the feature label Oct 30, 2014
@JDutil JDutil added this to the v3.0.x milestone Oct 30, 2014
@alepore
Copy link
Member

alepore commented Nov 28, 2014

oh 👍 to this, in italy states are "province" and i always have this problem

@JDutil
Copy link
Member

JDutil commented Dec 1, 2014

Now that master branches are targeting v3 I think it would be okay to make this change if someone would like to work up PRs

@marwinism
Copy link
Contributor

Ah, working on the norwegian translation (It was marked as 75% completed, was more like 2%) - But the "state" left me confused - So this is a most welcoming change!

@futhr
Copy link
Contributor

futhr commented Dec 20, 2014

I'm working on to clean up the locales for master branch now (just preparing a PR), I actually removed :nb because it had only 2% translated keys (that's 5min work). I also removed all :en translations in non :en locales because they fallback blockers.

@alepore
Copy link
Member

alepore commented May 24, 2015

@futhr there some work on this?
otherwise i'll look at it

@alepore
Copy link
Member

alepore commented Jun 9, 2015

ok, two solutions here:

  • add an address_state key for address stuff
  • move all the non-address "state" to "status"

thoughts?

@tvdeyen
Copy link
Contributor

tvdeyen commented Jun 9, 2015 via email

@alepore
Copy link
Member

alepore commented Jun 9, 2015

@mamhoff
Copy link
Contributor

mamhoff commented Jun 9, 2015

+1 for renaming state into status

@alepore
Copy link
Member

alepore commented Jun 13, 2015

note that status already exists https://github.com/spree/spree/search?utf8=%E2%9C%93&q=%22Spree.t%28%3Astatus%29%22&type=Code and the two terms are not really synonyms, i read...

@futhr
Copy link
Contributor

futhr commented Jun 13, 2015

Well, I always find the naming convention of "state" used as synonym for "region" or "province" being most confusing rather then "state" versus "status" that do little harm for the end-users if they gets mixed up. But in American English (that is Spree default) rather then International English, "state" is most natural in definition for U.S. states, but this naming convention do not apply well in an international concept where "region" or "province" would feel more natural.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants