Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orders which contain a tax refund cannot checkout. #17

Closed
Hates opened this issue Aug 13, 2013 · 1 comment
Closed

Orders which contain a tax refund cannot checkout. #17

Hates opened this issue Aug 13, 2013 · 1 comment

Comments

@Hates
Copy link
Contributor

Hates commented Aug 13, 2013

If an order is to a zone which requires a tax refund, then during checkout Paypal returns the error PayPal failed. Tax total is invalid. as the tax amount will be a minus amount, i.e. -£5.00.

Changing this so that the tax amount is zero if a minus amount then returns the error PayPal failed. The totals of the cart item amounts do not match order amounts..

Including tax_adjustments in the initial request line items resolves the issue for me:

Hates@c5629ff

You may have a better fix than the one I did. I just needed a quick fix for production.

@alepore
Copy link
Member

alepore commented Nov 25, 2014

👍 just faced this problem, and old problem... spree-contrib/spree_paypal_express#107

alepore added a commit to alepore/better_spree_paypal_express that referenced this issue Nov 29, 2014
alepore added a commit to alepore/better_spree_paypal_express that referenced this issue Nov 29, 2014
alepore added a commit to alepore/better_spree_paypal_express that referenced this issue Nov 29, 2014
@alepore alepore closed this as completed Jun 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants