Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.1 - Warnings on Admin pages #63

Open
dregad opened this issue Oct 26, 2022 · 7 comments
Open

PHP 8.1 - Warnings on Admin pages #63

dregad opened this issue Oct 26, 2022 · 7 comments

Comments

@dregad
Copy link

dregad commented Oct 26, 2022 •
edited
Loading 

Warning: Undefined array key "no" in .../dokuwiki/lib/plugins/sync/admin.php on line 20

Occurs with PHP 8.1 / DokuWiki Igor when accessing the Admin page (http://path.to/dokuwiki/doku.php?id=index&do=admin)
@dregad
Copy link
Author

dregad commented Oct 26, 2022 •
edited
Loading

Also on http://path.to/dokuwiki/doku.php?id=index&do=admin&page=sync

Warning: Undefined array key "sync_pages" in .../dokuwiki/lib/plugins/sync/admin.php on line 110
Warning: Undefined array key "sync_media" in .../dokuwiki/lib/plugins/sync/admin.php on line 110
Warning: Undefined array key "startsync" in .../dokuwiki/lib/plugins/sync/admin.php on line 145

The next 2 warnings occur on lines 284, 288, 300, 303, 311, 314, 317

Warning: Undefined array key "" in .../dokuwiki/lib/plugins/sync/admin.php
Warning: Trying to access array offset on value of type null in .../dokuwiki/lib/plugins/sync/admin.php

@dregad dregad changed the title PHP Warning on Admin page PHP 8.1 - Warnings on Admin pages Oct 26, 2022
gturri added a commit to gturri/dokuwiki-plugin-sync that referenced this issue Nov 29, 2022
@gturri
remove some warnings observed with PHP 8.1
21ef19f 
This fixes concerns reported by splitbrain#63 that I've also observed on my side.
(Note that this does not fix every warnings, but most of those already.
 I've also observed some near line 560 because when the key 'local' is
 not defined. I'm not really sure how this corner case should be fixed.
 Anyway, I guess the leftover could probably be tackled by future PR,
 given that this one already improves a bit the situation)
@gturri gturri mentioned this issue Nov 29, 2022
Closed
gturri added a commit to gturri/dokuwiki-plugin-sync that referenced this issue Dec 1, 2022
@gturri
remove some warnings observed with PHP 8.1
e0e8c2c 
This fixes concerns reported by splitbrain#63 that I've also observed on my side.
(Note that this does not fix every warnings, but most of those already.
 I've also observed some near line 560 because when the key 'local' is
 not defined. I'm not really sure how this corner case should be fixed.
 Anyway, I guess the leftover could probably be tackled by future PR,
 given that this one already improves a bit the situation)
gturri added a commit to gturri/dokuwiki-plugin-sync that referenced this issue Dec 4, 2022
@gturri
remove some warnings observed with PHP 8.1
c76d72e 
This fixes concerns reported by splitbrain#63 that I've also observed on my side.
(Note that this does not fix every warnings, but most of those already.
 I've also observed some near line 560 because when the key 'local' is
 not defined. I'm not really sure how this corner case should be fixed.
 Anyway, I guess the leftover could probably be tackled by future PR,
 given that this one already improves a bit the situation)
gturri added a commit to gturri/dokuwiki-plugin-sync that referenced this issue Dec 4, 2022
@gturri
remove some warnings observed with PHP 8.1
0c8901e 
This fixes concerns reported by splitbrain#63 that I've also observed on my side.
(Note that this does not fix every warnings, but most of those already.
 I've also observed some near line 560 because when the key 'local' is
 not defined. I'm not really sure how this corner case should be fixed.
 Anyway, I guess the leftover could probably be tackled by future PR,
 given that this one already improves a bit the situation)
gturri added a commit to gturri/dokuwiki-plugin-sync that referenced this issue Dec 4, 2022
@gturri
remove some warnings observed with PHP 8.1
f57d1d2 
This fixes concerns reported by splitbrain#63 that I've also observed on my side.
gturri added a commit to gturri/dokuwiki-plugin-sync that referenced this issue Dec 4, 2022
@gturri
remove some warnings observed with PHP 8.1
ae2d686 
This fixes concerns reported by splitbrain#63 that I've also observed on my side.
@dregad
Copy link
Author

dregad commented Aug 23, 2023

@splitbrain considering your recent note in @gturri's PR (#65 (comment))

this is all moot considering that this plugin needs more cleanup anyway and that I had started the cleanup a long while ago in the refactor branch. Unfortunately I got distracted and never finished it...

When you say this is all moot, does this mean that you would not be accepting further PRs patching this issue (or other quick / compatibility fixes), due to the pending refactor ?

If not, are you planning to resume the refactoring effort at some point ? Or should this plugin be considered dead / unsupported ?

@splitbrain
Copy link
Owner

I would accept pull requests on top of the refactor branch. I plan on resume working on it in the future. But the future may be years ahead. Alternatively you can always hire me via CosmoCode...

@dregad
Copy link
Author

dregad commented Aug 23, 2023

OK, fair enough.

Alternatively you can always hire me via CosmoCode...

Sadly the poor non-profit organizations I use this plugin for most likely can't afford your rates 🤑

Code contributions is really the best I could offer. Do you reckon the refactor branch is in a more-or-less usable state ? If so I could consider beta-testing it and providing patches.

@splitbrain
Copy link
Owner

Do you reckon the refactor branch is in a more-or-less usable state

I really do not remember. The biggest change was that instead of passing each file as a single POST variable JSON is exchanged with the backend to avoid running into limits with too many variables when a lot has changed. Or at least that was the plan. I really don't remember how far I came...

@dregad
Copy link
Author

dregad commented Aug 23, 2023

OK I guess I'll just wait for a few years then 😉

@splitbrain
Copy link
Owner

just give it try...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@splitbrain @dregad