fix: filter expressions within the tablescan should also be rewritten #36
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sevenannn
changed the title
Sevenannn
force-pushed
the
qianqian/clickbench-rewrite
branch
from
137336b to
ed36e33
Compare
ewgenius
approved these changes
Jan 4, 2025
phillipleblanc
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
When rewritting the expressions, the filter expressions within the table scan were ignored previously. This PR fixes the issue by rewritting Filter expressions within the tablescan.
🔨 Related Issues
🤔 Concerns