Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step size calculation not always correct #341

Open
canismarko opened this issue Jan 13, 2025 · 1 comment
Open

Step size calculation not always correct #341

canismarko opened this issue Jan 13, 2025 · 1 comment
Assignees
Labels
bug Something isn't working Firefly Issues related to the Firefly GUI system

Comments

@canismarko
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

The line scan plan window displays the step size for each axis based on the range inputs and num of scan points. In at least one case this gives nonsensical results.

To Reproduce
Steps to reproduce the behavior:

  1. Open the line scan window
  2. Enter a range of -20 to 20
  3. Observe the calculated step size

Expected behavior
A clear and concise description of what you expected to happen.

With the default scan points of 2, the step size should be 20, but instead some large number is presented.

Screenshots
If applicable, add screenshots to help explain your problem.

image

Additional context
Oddly, if I change the scan points to 3 and then back to 2, the correct number is displayed. Maybe there's some caching happening here? I think this only happens if the scan points is not changed from its default value.

@canismarko canismarko added bug Something isn't working Firefly Issues related to the Firefly GUI system labels Jan 13, 2025
@Cathyhjj
Copy link
Collaborator

Fixed in 5b64c7f, will create another PR after new changes are included into the plan windows, such as including the chemical formula line Edits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Firefly Issues related to the Firefly GUI system
Projects
None yet
Development

No branches or pull requests

2 participants