Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX improvements to the area detector viewer #232

Open
6 tasks
canismarko opened this issue Jun 24, 2024 · 7 comments
Open
6 tasks

UX improvements to the area detector viewer #232

canismarko opened this issue Jun 24, 2024 · 7 comments
Assignees
Labels
Firefly Issues related to the Firefly GUI system
Milestone

Comments

@canismarko
Copy link
Contributor

canismarko commented Jun 24, 2024

During initial commissioning, we used the area_detector.ui window for BPM camera. Sometimes this camera disconnects, but there is no obvious indication that this has happened.

We should at least add labels for the following:

  • number of frames collected
  • detector state
  • frame rate

Also fix:

  • overlay controls
  • ROI controls

Add:

  • Horizontal splitter
@canismarko canismarko added the Firefly Issues related to the Firefly GUI system label Jun 24, 2024
@canismarko canismarko added this to the User Support milestone Jun 24, 2024
@canismarko canismarko assigned canismarko and yannachen and unassigned canismarko Jul 12, 2024
@yannachen
Copy link
Collaborator

No minimum/maximum values for the slider in the previous version. I will update in a new pull request.

@yannachen
Copy link
Collaborator

The slider is still not working after changing the PyDMslider channel to "ca://25idSimDet:Over1:1:CenterX." Temporarily, we set the sliders' limits from 0 to 3000 to make slider working.

@canismarko
Copy link
Contributor Author

Temporarily, we set the sliders' limits from 0 to 3000 to make slider working.

Yes, but that creates its own UX issues when the range doesn't match the image size. How about we find a time to dig into the PyDM code and see what's going on?

@canismarko
Copy link
Contributor Author

I think we're ready to move forward on this. I created an Aravis-based area detector device in ophyd-async: https://github.com/spc-group/haven/blob/main/src/haven/devices/detectors/aravis.py

I think we can now add back in controls for the rest of the plugins that we need, but those plugins aren't part of the device yet, so need to add them. Here are the steps that I see:

  1. Identify which plugins we need widgets for (e.g. overlays)
  2. Add those plugins as devices to the main AravisDetector device
  3. Update the UI widgets to connect with those new signals
  4. Make sure it is easy for users to interact with the UI
  • I don't think we need to do ROI or stats anymore since the group decided it was better to do ROI handling as part of the analysis rather than data acquisition.

@yannachen
Copy link
Collaborator

  1. Shape width was added in overlays;
  2. AravisDetector has connection status, exposure, gain and image saving size;
  3. For exposure/gain, once Continous checkbox is checked, Auto is disabled; Auto button can be clicked after unchecking Continous;
  4. Pytest has passed; Testing Firely-Dev from account yannachen shows well except for choosing the overlay shape and shape size/center. Need to see in Firefly.

@yannachen
Copy link
Collaborator

Pull request has 3 errors, but not from this task. I am not sure how to deal with it.

@canismarko
Copy link
Contributor Author

Pull request has 3 errors, but not from this task. I am not sure how to deal with it.

Okay, I'll take a look and respond in the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Firefly Issues related to the Firefly GUI system
Projects
None yet
Development

No branches or pull requests

2 participants