-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creation of dynamic property errors #103
Comments
yeah 'monitorName' is not working for me as well |
Dear contributor, because this issue seems to be inactive for quite some time now, I've automatically closed it. If you feel this issue deserves some attention from my human colleagues feel free to reopen it. |
Hi, sorry, the issue still persists and I'd like to ask to reopen it, especially since there is a related PR open here: #114 |
Since PR #114 was released, I don't see any warnings in laravel.log |
After upgrading to PHP 8.2 i get a lot of errors, because i am setting a gracetime, name or donotmonitor in the scheduler. For example:
Creation of dynamic property Illuminate\Console\Scheduling\Event::$monitorName is deprecated in …vendor/spatie/laravel-schedule-monitor/src/ScheduleMonitorServiceProvider.php on line 113
or
Creation of dynamic property Illuminate\Console\Scheduling\CallbackEvent::$monitorName is deprecated in …vendor/spatie/laravel-schedule-monitor/src/ScheduleMonitorServiceProvider.php on line 113
The fix from #93 does not work, because we try to get those props from
Illuminate\Console\Scheduling\Event
andIlluminate\Console\Scheduling\CallbackEvent
.As stated here https://www.php.net/manual/en/migration82.deprecated.php:
Both
Illuminate\Console\Scheduling\Event
andIlluminate\Console\Scheduling\CallbackEvent
do not support this right now.So this cant be fixed within the scope of this package or are there any ideas?
Maybe this is fixed in Laravel 11 which will have a min. PHP version of 8.2?
The text was updated successfully, but these errors were encountered: