Improve cache for PermissionRegistrar

[4n70w4]

laravel-permission/src/PermissionRegistrar.php

Line 131 in 753ce00

$permissions = $permissions->where($attr, $value);

For cases 200+ permissions and 100+ permission checks for request usage of \Illuminate\Support\Collection::where utilize up to 20% of CPU.

Also why clone $permissions?

laravel-permission/src/PermissionRegistrar.php

Line 128 in 753ce00

$permissions = clone $this->permissions;

Some patch reduces CPU consumption by 20% for large complex applications

Index: vendor/spatie/laravel-permission/src/PermissionRegistrar.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- vendor/spatie/laravel-permission/src/PermissionRegistrar.php	(date 1574166891415)
+++ vendor/spatie/laravel-permission/src/PermissionRegistrar.php	(date 1574166891415)
@@ -136,11 +136,12 @@
             });
         }
 
-        $permissions = clone $this->permissions;
+        $permissions = $this->permissions;
 
+        $permissions = $this->cache->remember(self::$cacheKey . implode(',', $params) . implode(',', array_keys($params)), self::$cacheExpirationTime, function () {
         foreach ($params as $attr => $value) {
             $permissions = $permissions->where($attr, $value);
-        }
+        }});
 
         return $permissions;
     }

[4n70w4]

Before patch:

and Redis calls (5): 4.14 ms

After patch:

and Redis calls (37): 14.1 ms