Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types v9 #1808

Closed
rcerljenko opened this issue Jul 2, 2024 · 3 comments
Closed

Types v9 #1808

rcerljenko opened this issue Jul 2, 2024 · 3 comments

Comments

@rcerljenko
Copy link
Contributor

Hi,

This happens when you set null on that config in v9:

image
@rcerljenko
Copy link
Contributor Author

Also, notifications.mail.to used to accept array because Laravel accepts it too in mail handler so you could send notification to multiple emails at once, but now, via config DTO, it only accepts string. :( could that be changed to also accept string|array ?

@rcerljenko rcerljenko mentioned this issue Jul 2, 2024
Closed
@rcerljenko
Copy link
Contributor Author

I made a PR to fix this: #1809

@freekmurze
Copy link
Member

We'll handle this further in the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@freekmurze @rcerljenko