Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules using gRPC bidirectional requests may not be properly implemented #42

Open
AliabbasMerchant opened this issue Aug 13, 2019 · 0 comments

Comments

@AliabbasMerchant
Copy link
Contributor

AliabbasMerchant commented Aug 13, 2019

Not sure, never tested. This is just a causal observation

self.async_result = self.run_pool.apply_async(self._run_client, (self.id,))
options = obj_to_utf8_bytes({"skipInitial": self.skip_initial})
self.pool.map(self._send, (
server_pb2.RealTimeRequest(token=self.token, dbType=self.db_type, project=self.project_id,
                           group=self.collection, options=options,
                           type=constants.TypeRealtimeSubscribe, id=self.id,
                           where=obj_to_utf8_bytes(self.find)),))

This is done everytime subscribe is called.
This may result in self.subscription being overwritten everytime, resulting in wrong functions being called

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant