Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more consistent FresnelOpticalSystem and OpticalSystem APIs #292

Open
mperrin opened this issue Feb 12, 2019 · 0 comments
Open

more consistent FresnelOpticalSystem and OpticalSystem APIs #292

mperrin opened this issue Feb 12, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@mperrin
Copy link
Collaborator

mperrin commented Feb 12, 2019

See comments on #290: #290 (comment)

It would ease the learning curve if both FresnelOpticalSystem and OpticalSystem had APIs as consistent as possible, in terms of how they define the wavefront sampling parameters (oversample vs. beam ratio etc). Probably a good idea to refactor & clarify this API eventually, but if we're going to do so, we should make sure the revised API is one that we'll be happy with in the long run.
@mperrin mperrin added the enhancement New feature or request label Feb 19, 2019
@mperrin mperrin added this to the Fall 2019 release milestone May 9, 2019
@mperrin mperrin modified the milestones: Winter 2019 release, 0.9.2 Jun 19, 2020
@mperrin mperrin removed this from the 1.0.0 milestone Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mperrin