Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectrum1D glue data translator needs to handle uncertainty and mask #200

Closed
ibusko opened this issue Jul 27, 2020 · 3 comments
Closed

Spectrum1D glue data translator needs to handle uncertainty and mask #200

ibusko opened this issue Jul 27, 2020 · 3 comments

Comments

@ibusko
Copy link
Contributor

ibusko commented Jul 27, 2020

When implementing code to support plotting of errors and masks in specviz, we found that the glue data translator Specutils1DHandler doesn't handle any array attribute besides the flux array.

It needs to handle at least the error array coming from the uncertainty attribute, and the mask array coming from the mask attribute (any need to handle more complex masks?)

This issue seems to affect other tickets currently in development in daviz.

@nmearl
Copy link
Contributor

nmearl commented Jul 27, 2020

This is being handled in the PR to glue-astronomy: glue-viz/glue-astronomy#19.

@rosteen
Copy link
Collaborator

rosteen commented Jul 27, 2020

That PR is for fixing the returned mask attribute to match the convention that specutils expects, but does not currently do anything to address the need for the uncertainty attribute. I create a follow-up issue in glue-astronomy about uncertainty and handling more complex masks.

EDIT: Ignore this comment, I thought that link was to a different PR.

@rosteen
Copy link
Collaborator

rosteen commented Sep 4, 2020

The glue-astronomy PR implementing this was merged, closing this issue.

@rosteen rosteen closed this as completed Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants