Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Mode and HilbertSpace to Eigenmode and Eigenspace #6

Open
sp94 opened this issue Sep 19, 2020 · 0 comments
Open

Rename Mode and HilbertSpace to Eigenmode and Eigenspace #6

sp94 opened this issue Sep 19, 2020 · 0 comments
Labels
breaking Will change the interface enhancement New feature or request
Milestone
v0.2

Comments

@sp94
Copy link
Owner

sp94 commented Sep 19, 2020

Mode is for storing an eigenvector that has an associated eigenvalue.

HilbertSpace(modes) takes the modes, discards the eigenvalues, and orthonormalises the eigenvectors - useful for then calculating new eigenmodes, such as those of symmetry operators or Wilson loop operators.

I think renaming Mode to Eigenmode and HilbertSpace to Eigenspace will make this intention clearer.
@sp94 sp94 added enhancement New feature or request breaking Will change the interface labels Sep 19, 2020
@sp94 sp94 added this to the v0.2 milestone Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Will change the interface enhancement New feature or request
Projects
None yet
Milestone
v0.2
Development

No branches or pull requests
1 participant
@sp94