Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I cant see item's variants. Please Fix it!!!!! #7862

Open
Daenerys34 opened this issue Jan 12, 2025 · 9 comments
Open

I cant see item's variants. Please Fix it!!!!! #7862

Daenerys34 opened this issue Jan 12, 2025 · 9 comments

Comments

@Daenerys34
Copy link

Axolot's buckets, horns, paintings, rockets are invisible. Nbt Variants are not working help us!

@sp614x
Copy link
Owner

sp614x commented Jan 12, 2025

MC version, OF version, resource pack?

@Daenerys34
Copy link
Author

1.21.4 in texture, the new optifine pre 11

@sp614x
Copy link
Owner

sp614x commented Feb 2, 2025

What resource pack are you using?
If it uses older unsupported features there should be warnings in the error log.

@Daenerys34
Copy link
Author

Mizuno's 16 craft

@sp614x
Copy link
Owner

sp614x commented Feb 4, 2025

[Render thread/WARN]: [OptiFine] Invalid NBT check: nbt.Variant=0
[Render thread/WARN]: [OptiFine] Invalid NBT checks specified: optifine/cit/axolotl_bucket/axolotl_bucket_0.properties
[Render thread/WARN]: [OptiFine] Invalid NBT check: nbt.Variant=1
[Render thread/WARN]: [OptiFine] Invalid NBT checks specified: optifine/cit/axolotl_bucket/axolotl_bucket_1.properties
[Render thread/WARN]: [OptiFine] Invalid NBT check: nbt.Variant=2
[Render thread/WARN]: [OptiFine] Invalid NBT checks specified: optifine/cit/axolotl_bucket/axolotl_bucket_2.properties
[Render thread/WARN]: [OptiFine] Invalid NBT check: nbt.Variant=3
[Render thread/WARN]: [OptiFine] Invalid NBT checks specified: optifine/cit/axolotl_bucket/axolotl_bucket_3.properties
[Render thread/WARN]: [OptiFine] Invalid NBT check: nbt.Variant=4
[Render thread/WARN]: [OptiFine] Invalid NBT checks specified: optifine/cit/axolotl_bucket/axolotl_bucket_4.properties

The NBT checks were replaced with component checks in 1.21.4: https://github.com/sp614x/optifine/blob/master/OptiFineDoc/doc/cit_single.properties#L128

@sp614x
Copy link
Owner

sp614x commented Feb 4, 2025

Added backwards compatibility fix for the axolotl variants.

@sp614x
Copy link
Owner

sp614x commented Feb 4, 2025

The Mizuno's CIT pack complains about missing texture references, it has to be updated to 1.21.4:

Missing textures in model minecraft:optifine/cit/spruce_sapling_1#inventory: minecraft:textures/atlas/blocks.png:minecraft:block/flower_pot_1
Missing textures in model minecraft:optifine/cit/cake_0b#inventory: minecraft:textures/atlas/blocks.png:minecraft:block/cake_inner_1, minecraft:textures/atlas/blocks.png:minecraft:block/cake_side_1, minecraft:textures/atlas/blocks.png:minecraft:block/cake_top_1
Missing textures in model minecraft:optifine/cit/flower_pot_0b#inventory: minecraft:textures/atlas/blocks.png:minecraft:block/flower_pot_1
Missing textures in model minecraft:optifine/cit/flower_pot_0a#inventory: minecraft:textures/atlas/blocks.png:minecraft:block/flower_pot_0
Missing textures in model minecraft:optifine/cit/cake_0a#inventory: minecraft:textures/atlas/blocks.png:minecraft:block/cake_inner_0, minecraft:textures/atlas/blocks.png:minecraft:block/cake_side_0, minecraft:textures/atlas/blocks.png:minecraft:block/cake_top_0
Missing textures in model minecraft:optifine/cit/spruce_sapling_0#inventory: minecraft:textures/atlas/blocks.png:minecraft:block/flower_pot_1
Missing textures in model minecraft:optifine/cit/snow_block_1#inventory: minecraft:textures/atlas/blocks.png:minecraft:block/red_wool_side
Missing textures in model minecraft:optifine/cit/snow_block_1a#inventory: minecraft:textures/atlas/blocks.png:minecraft:block/green_wool_side, minecraft:textures/atlas/blocks.png:minecraft:block/red_wool_side
Missing texture references in model minecraft:optifine/cit/water_bottle_2#inventory: particle
Missing texture references in model minecraft:optifine/cit/painting_4c#inventory: particle
Missing texture references in model minecraft:optifine/cit/cauldron_4d#inventory: particle
Missing texture references in model minecraft:optifine/cit/birch_sign_open#inventory: particle
Missing texture references in model minecraft:optifine/cit/milk_bucket_4#inventory: particle
Missing texture references in model minecraft:optifine/cit/torch_1#inventory: particle
Missing texture references in model minecraft:optifine/cit/dark_oak_sign_shepherd#inventory: particle
Missing texture references in model minecraft:optifine/cit/blue_carpet_0a#inventory: particle
Missing texture references in model minecraft:optifine/cit/jungle_sign_library#inventory: particle
Missing texture references in model minecraft:optifine/cit/sugar_5#inventory: particle
Missing texture references in model minecraft:optifine/cit/bamboo_0#inventory: particle
Missing texture references in model minecraft:optifine/cit/spruce_sign_coffee#inventory: particle
Missing texture references in model minecraft:optifine/cit/chest_0#inventory: particle
Missing texture references in model minecraft:optifine/cit/gold_block_1#inventory: particle

@ZenithRogue
Copy link
Collaborator

Added backwards compatibility fix for the axolotl variants.

@sp614x This will cause issues with other competing components. nbt.Variant has been split between both minecraft:bucket_entity_data.Variant and minecraft:entity_data.Variant

@ZenithRogue
Copy link
Collaborator

ZenithRogue commented Feb 4, 2025

Any components can be added to any item as well, so adding backwards compatibility can have unintended consequences. Skipping most backwards compatibility fixes would be optimal/preferred

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants