Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post ws notification is received multiple times after you destroy the controller #83

Open
alleles opened this issue Apr 11, 2018 · 2 comments

Comments

@alleles
Copy link

alleles commented Apr 11, 2018

the $onDestroy function is being overwritten each time you subscribe within a controller.. which means only the last subscription you make is actually getting destroyed..

i have a fix.. will put in a PR

ty for this project.. i've literally been using it for years for all sorts of POCs..

@alleles
Copy link
Author

alleles commented Apr 11, 2018

fixed commit here:

alleles@0e8c4e1
cheers!

@soygul
Copy link
Owner

soygul commented Apr 16, 2018

Good point. I may include this in the next release with package updates. Or I might remove the entire memory leak protection code and make a comment linking to your commit, just to keep the example as simple as possible.

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants