Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile Workspace: Module tab reloading on each keystroke in editor #168

Closed
martin-henz opened this issue Jan 29, 2023 · 4 comments · Fixed by source-academy/frontend#2331
Closed

Mobile Workspace: Module tab reloading on each keystroke in editor #168

martin-henz opened this issue Jan 29, 2023 · 4 comments · Fixed by source-academy/frontend#2331
Labels
Bug [Category] critical [Priority] Fixing this is mission-critical

Comments

@martin-henz
Copy link
Member

Expected Behavior

Editor keystrokes should not affect module loading.

Current Behavior

Currently each editor keystroke reloads the currently loaded modules.

Steps to Reproduce

  1. Load: https://share.sourceacademy.org/oxhil
  2. press run
  3. open the runes tab
  4. start typing in editor

you will see that each keystroke restarts the animation.

Context

This is a critical issue in modules. Fixing it is necessary for current CS1101S.
@martin-henz martin-henz added Bug [Category] critical [Priority] Fixing this is mission-critical labels Jan 29, 2023
@ianyong ianyong mentioned this issue Jan 29, 2023
Merged
5 tasks
@ianyong
Copy link
Member

ianyong commented Jan 29, 2023

Fixed the desktop workspace through the use of memoization in source-academy/frontend#2331, but the mobile workspace still has this issue because the mobileControlBarProps being passed into it is constantly updating (thus making memoization ineffective). Possibly need to either memoize more components/variables in the code or refactor such that the side content tabs are not re-rendered when the control bar re-renders.

@ianyong ianyong reopened this Jan 29, 2023
@martin-henz martin-henz reopened this Jan 29, 2023
@martin-henz
Copy link
Member Author

Reopening after renaming: The problem persists for mobile workspace, see
source-academy/frontend#2331

@martin-henz martin-henz changed the title General: Module tab reloading on each keystroke in editor Mobile Workspace: Module tab reloading on each keystroke in editor Jan 29, 2023
@martin-henz
Copy link
Member Author

The issue should move to frontend

@martin-henz martin-henz mentioned this issue Jan 29, 2023
Open
@martin-henz
Copy link
Member Author

Closed in favor of: source-academy/frontend#2332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug [Category] critical [Priority] Fixing this is mission-critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix unnecessary rerendering of side content in desktop workspace source-academy/frontend
2 participants
@ianyong @martin-henz