Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make repeated notifications less intrusive #2402

Open
pyBlob opened this issue Apr 1, 2023 · 1 comment
Open

Make repeated notifications less intrusive #2402

pyBlob opened this issue Apr 1, 2023 · 1 comment
Labels
Enhancement New feature request proposal Tentative suggestion inviting discussion

Comments

@pyBlob
Copy link

pyBlob commented Apr 1, 2023

  • I keep getting this popup, even though the last update on github happened more than an hour ago:
    "A new version of Source Academy is available. Please refresh the browser."
  • I opened the network tab, to see whether it performs a request that checks for an update. Though, that does not seem to be the case. It just opens the popup.
  • Loading the page with "Disable cache" fetches all new pages, but the popup still keeps showing up.

This is annoying while reading the book, and the popup may even stack multiple times.

I would suggest to get rid of this popup entirely, and just force a reload when the user clicks on a link to navigate to the next chapter?

Edit: After having to reload the browser, because the goto definition on the huge pretty-printed main.js locked up everything ... The popup is gone? 🤔

@RichDom2185 RichDom2185 added Enhancement New feature request proposal Tentative suggestion inviting discussion labels May 16, 2023
@RichDom2185
Copy link
Member

It seems like the main issue is not with the popup appearing, but instead, our handling/stacking of multiple notifications (e.g. "A new version", 401/403 errors), that can be intrusive to the user experience.

@RichDom2185 RichDom2185 changed the title "A new version" popup keeps showing up Make repeated notifications less intrusive May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature request proposal Tentative suggestion inviting discussion
Projects
None yet
Development

No branches or pull requests

2 participants