Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor XMLGenerator #193

Open
indocomsoft opened this issue Aug 8, 2018 · 4 comments
Open

Refactor XMLGenerator #193

indocomsoft opened this issue Aug 8, 2018 · 4 comments
Labels
nice-to-have Issue is a non-critical, non-important

Comments

@indocomsoft
Copy link
Member

No description provided.

@indocomsoft indocomsoft added the nice-to-have Issue is a non-critical, non-important label Aug 8, 2018
@martin-henz
Copy link
Member

@indocomsoft can you explain in what way it needs to be refactored?

@indocomsoft
Copy link
Member Author

Refactoring using macros, cos right now I have to keep on creating new functions for each tag. Instead the block could be passed to a macro that will automatically convert each function to a new tag.

This is strictly very low priority, cos its only used for testing the xml parser.

@martin-henz
Copy link
Member

OK, will keep it around as "_postponed".

@martin-henz martin-henz added the _postponed Postponed for now; to be visited later label Feb 14, 2019
@jiachen247 jiachen247 self-assigned this Jun 6, 2019
@jiachen247
Copy link
Contributor

I can work on this since im gonna be touching on the xml_parser!! will refractor accordingly.

@angelsl angelsl removed the _postponed Postponed for now; to be visited later label May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
nice-to-have Issue is a non-critical, non-important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@angelsl @indocomsoft @jiachen247 @martin-henz