Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing slash in URL breaks oEmbed #46

Open
sqpdln opened this issue Mar 26, 2021 · 0 comments
Open

Trailing slash in URL breaks oEmbed #46

sqpdln opened this issue Mar 26, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@sqpdln
Copy link

sqpdln commented Mar 26, 2021

Title: Trailing slash in URL breaks oEmbed

Issue found of: March 24th, 2021

Scope(s):

  • oEmbed

Steps to reproduce:

Example taken from your docs.

This works:

curl "https://soundcloud.com/oembed" -d 'format=json' -d 'url=https://soundcloud.com/forss/flickermood'

{"version":1.0,"type":"rich","provider_name":"SoundCloud","provider_url":"https://soundcloud.com","height":400,"width":"100%","title":"Flickermood by Forss","description":"From the Soulhack album,&nbsp;recently featured in this ad <a href=\"https://www.dswshoes.com/tv_commercial.jsp?m=october2007\">https://www.dswshoes.com/tv_commercial.jsp?m=october2007</a> ","thumbnail_url":"https://i1.sndcdn.com/artworks-000067273316-smsiqx-t500x500.jpg","html":"<iframe width=\"100%\" height=\"400\" scrolling=\"no\" frameborder=\"no\" src=\"https://w.soundcloud.com/player/?visual=true&url=https%3A%2F%2Fapi.soundcloud.com%2Ftracks%2F293&show_artwork=true\"></iframe>","author_name":"Forss","author_url":"https://soundcloud.com/forss"}%

This does not work:

curl -v "https://soundcloud.com/oembed" -d 'format=json' -d 'url=https://soundcloud.com/forss/flickermood/'

{...}
HTTP/1.1 404 Not Found
{...}

Expected behaviour:

Url with trailing slash should work, alternatively make it clear in the docs trailing slashes are not allowed.

Actual behaviour:

HTTP/1.1 404 Not Found

@rahul-sc rahul-sc added the bug Something isn't working label May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants