From 795e50daacccbe007a933aa8213c58ca02cd2d7a Mon Sep 17 00:00:00 2001 From: Ofir Gordon Date: Thu, 13 Feb 2025 13:58:15 +0200 Subject: [PATCH] Fix simple symmetric selection pr comments --- .../test_symmetric_selection_activation.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests_pytest/unit_tests/common/core/quantization/quantization_params_generation/test_symmetric_selection_activation.py b/tests_pytest/unit_tests/common/core/quantization/quantization_params_generation/test_symmetric_selection_activation.py index 2ff0c4817..165f80bc9 100644 --- a/tests_pytest/unit_tests/common/core/quantization/quantization_params_generation/test_symmetric_selection_activation.py +++ b/tests_pytest/unit_tests/common/core/quantization/quantization_params_generation/test_symmetric_selection_activation.py @@ -37,6 +37,7 @@ def hist(): @pytest.fixture def bounded_hist(): + # here, we want to test the threshold selection for np.random.seed(42) size = (32, 32, 3) num_bins = 2048 @@ -48,7 +49,7 @@ def bounded_hist(): return count, bins -err_methods_to_test = [e.name for e in QuantizationErrorMethod if e != QuantizationErrorMethod.HMSE] +err_methods_to_test = [e for e in QuantizationErrorMethod if e != QuantizationErrorMethod.HMSE] @pytest.mark.parametrize("error_method", err_methods_to_test) @@ -56,7 +57,7 @@ def test_symmetric_threshold_selection(error_method, hist): counts, bins = hist search_res = symmetric_selection_histogram(bins, counts, 2, 8, Mock(), Mock(), Mock(), Mock(), - MIN_THRESHOLD, QuantizationErrorMethod[error_method], True) + MIN_THRESHOLD, error_method, True) assert THRESHOLD in search_res assert SIGNED in search_res @@ -69,7 +70,7 @@ def test_symmetric_threshold_selection_bounded_activation(error_method, bounded_ counts, bins = bounded_hist search_res = symmetric_selection_histogram(bins, counts, 2, 8, Mock(), Mock(), Mock(), Mock(), - MIN_THRESHOLD, QuantizationErrorMethod[error_method], False) + MIN_THRESHOLD, error_method, False) assert THRESHOLD in search_res assert SIGNED in search_res