From 0920122395afa9978c764f1b432b0bb39a406d56 Mon Sep 17 00:00:00 2001 From: trying-cui Date: Thu, 20 Jul 2017 19:18:36 +0800 Subject: [PATCH] fix bug about spring bean scope singleton --- .../web/component/EmailComponentImpl.java | 12 ++-------- .../component/MobileAlertComponentImpl.java | 23 +++++++------------ 2 files changed, 10 insertions(+), 25 deletions(-) diff --git a/cachecloud-open-common/src/main/java/com/sohu/cache/web/component/EmailComponentImpl.java b/cachecloud-open-common/src/main/java/com/sohu/cache/web/component/EmailComponentImpl.java index c80b8efa..82b2c486 100644 --- a/cachecloud-open-common/src/main/java/com/sohu/cache/web/component/EmailComponentImpl.java +++ b/cachecloud-open-common/src/main/java/com/sohu/cache/web/component/EmailComponentImpl.java @@ -21,11 +21,9 @@ public class EmailComponentImpl implements EmailComponent { private final Logger logger = LoggerFactory.getLogger(EmailComponentImpl.class); - private String adminEmail = ConstUtils.EMAILS; - @Override public boolean sendMailToAdmin(String title, String content) { - return sendMail(title, content, Arrays.asList(adminEmail)); + return sendMail(title, content, Arrays.asList(ConstUtils.EMAILS)); } @Override @@ -60,15 +58,9 @@ public boolean sendMail(String title, String content, List emailList, Li } } - public void setAdminEmail(String adminEmail) { - this.adminEmail = adminEmail; - } - @Override public String getAdminEmail() { - return adminEmail; + return ConstUtils.EMAILS; } - - } diff --git a/cachecloud-open-common/src/main/java/com/sohu/cache/web/component/MobileAlertComponentImpl.java b/cachecloud-open-common/src/main/java/com/sohu/cache/web/component/MobileAlertComponentImpl.java index 5bc1398a..34723270 100644 --- a/cachecloud-open-common/src/main/java/com/sohu/cache/web/component/MobileAlertComponentImpl.java +++ b/cachecloud-open-common/src/main/java/com/sohu/cache/web/component/MobileAlertComponentImpl.java @@ -1,16 +1,15 @@ package com.sohu.cache.web.component; -import java.util.Arrays; -import java.util.HashMap; -import java.util.List; -import java.util.Map; - +import com.sohu.cache.util.ConstUtils; +import com.sohu.cache.web.util.HttpRequestUtil; import org.apache.commons.lang.StringUtils; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import com.sohu.cache.util.ConstUtils; -import com.sohu.cache.web.util.HttpRequestUtil; +import java.util.Arrays; +import java.util.HashMap; +import java.util.List; +import java.util.Map; /** * 手机短信报警 @@ -21,13 +20,11 @@ public class MobileAlertComponentImpl implements MobileAlertComponent { private final Logger logger = LoggerFactory.getLogger(MobileAlertComponentImpl.class); - /** - * 管理员电话 - */ - private String adminPhones = ConstUtils.PHONES; + @Override public void sendPhoneToAdmin(String message) { + String adminPhones = ConstUtils.PHONES; // 管理员电话 if (StringUtils.isBlank(message) || StringUtils.isBlank(adminPhones)) { logger.error("message is {}, maybe empty or adminPhones is {}, maybe empty", message, adminPhones); } @@ -57,8 +54,4 @@ public void sendPhone(String message, List phoneList) { logger.warn("send Done!"); } - public void setAdminPhones(String adminPhones) { - this.adminPhones = adminPhones; - } - }