Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary clearing of diagnostics #142

Open
piotmag769 opened this issue Jan 7, 2025 · 0 comments
Open

Unnecessary clearing of diagnostics #142

piotmag769 opened this issue Jan 7, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@piotmag769
Copy link
Contributor

Currently if there is a panic during diagnostics calculation we log an error and use a default value (empty diagnostics).

query!(db.module_semantic_diagnostics(module_id))
.map(Result::unwrap_or_default)
.unwrap_or_default()
.get_all(),

This can cause blinking of diagnostics bcs we may clear already existing ones. Instead we should use previously calculated diagnostics to not clear any existing diagnostics

@piotmag769 piotmag769 added the bug Something isn't working label Jan 7, 2025
@github-project-automation github-project-automation bot moved this to Triage in CairoLS Jan 7, 2025
@Arcticae Arcticae moved this from Triage to Backlog in CairoLS Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

1 participant