Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Denodo documentation - configuration template enhancement #775

Closed
teimahu opened this issue Apr 29, 2024 · 1 comment · Fixed by #777
Closed

Denodo documentation - configuration template enhancement #775

teimahu opened this issue Apr 29, 2024 · 1 comment · Fixed by #777

Comments

@teimahu
Copy link

teimahu commented Apr 29, 2024

Hi Soda developpers,

I tried to install the doc tooling with VSCode in order to create a PR, but I was not able to create a working env, sorry for this.
So I would just suggest to enhance an existing page in the documentation at this URL : https://docs.soda.io/soda/connect-denodo.html

This proposal follows those modifications made to the Denodo connection:

So "database" and "sslmode" parameters could be added to the Denodo page in the documentation, such as:

Connection configuration reference

Install package: soda-denodo

data_source my_datasource_name:
  type: denodo
  username: simple
  password: simple_pass
  host: 127.0.0.1
  port: 9996
  database: my_db
  sslmode: prefer
Property Required Notes
type required Identify the type of data source for Soda.
username required Consider using system variables to retrieve this value securely.
password required Consider using system variables to retrieve this value securely.
host required Provide a host identifier.
port required Provide a port identifier.
database required Provide a virtual database (VDB) name.
sslmode optionnal SSL support can be: prefer (default), require, allow, disable

Best regards,

@janet-can janet-can linked a pull request Apr 29, 2024 that will close this issue
@janet-can
Copy link
Contributor

Thanks for logging the issue, @teimahu ! I have added those parameters, and the connection_timeout one as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants