Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1820372: (from 947) when proxy is set in Connection, driver does send traffic through the proxy to S3, but not to Azure blob / GCS bucket (only Snowflake). Works with proxy envvar (GCP) #982

Merged
merged 54 commits into from
Jan 13, 2025

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the types in index.d.ts file (if necessary)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.06%. Comparing base (ea8a0a1) to head (7324fa3).

Files with missing lines Patch % Lines
lib/file_transfer_agent/gcs_util.js 84.61% 4 Missing ⚠️
lib/proxy_util.js 69.23% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #982      +/-   ##
==========================================
+ Coverage   88.97%   89.06%   +0.08%     
==========================================
  Files          72       72              
  Lines        6960     6985      +25     
==========================================
+ Hits         6193     6221      +28     
+ Misses        767      764       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib/file_transfer_agent/gcs_util.js Outdated Show resolved Hide resolved
lib/file_transfer_agent/gcs_util.js Outdated Show resolved Hide resolved
lib/file_transfer_agent/gcs_util.js Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
lib/file_transfer_agent/gcs_util.js Show resolved Hide resolved
lib/file_transfer_agent/gcs_util.js Show resolved Hide resolved
lib/file_transfer_agent/gcs_util.js Show resolved Hide resolved
lib/file_transfer_agent/gcs_util.js Show resolved Hide resolved
lib/proxy_util.js Outdated Show resolved Hide resolved
lib/util.js Outdated Show resolved Hide resolved
lib/file_transfer_agent/gcs_util.js Outdated Show resolved Hide resolved
lib/file_transfer_agent/gcs_util.js Outdated Show resolved Hide resolved
lib/file_transfer_agent/gcs_util.js Outdated Show resolved Hide resolved
lib/file_transfer_agent/gcs_util.js Outdated Show resolved Hide resolved
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy merged commit 3ab8b63 into master Jan 13, 2025
46 of 47 checks passed
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy deleted the SNOW-1820372 branch January 13, 2025 19:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants