Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1899127: log4net STDOUT logging bug #1085

Closed
Coder3333 opened this issue Jan 27, 2025 · 9 comments
Closed

SNOW-1899127: log4net STDOUT logging bug #1085

Coder3333 opened this issue Jan 27, 2025 · 9 comments
Assignees
Labels
bug status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. status-triage_done Initial triage done, will be further handled by the driver team

Comments

@Coder3333
Copy link
Contributor

There is a bug in the Snowflake .Net Connector code that prevents log4net from ever using the console logger. I have fixed the bug in the below PR. Please, consider accepting this PR, as it is a major blocker for us, and is a very minimal code change.

#1083

@Coder3333 Coder3333 added the bug label Jan 27, 2025
@github-actions github-actions bot changed the title log4net STDOUT logging bug SNOW-1899127: log4net STDOUT logging bug Jan 27, 2025
@sfc-gh-dszmolka sfc-gh-dszmolka added the status-triage_done Initial triage done, will be further handled by the driver team label Jan 27, 2025
@sfc-gh-dszmolka
Copy link
Contributor

hi - thank you for raising this one and the PR too! the team will review and decide; not sure if it will be implemented as we focus on removing log4net instead of patching it (see #1057) .

@Coder3333
Copy link
Contributor Author

hi - thank you for raising this one and the PR too! the team will review and decide; not sure if it will be implemented as we focus on removing log4net instead of patching it (see #1057) .

@sfc-gh-dszmolka ,
I am glad you are finally moving away from log4net, but this is a huge blocker for our Enterprise, as we do not use file logging, and the Snowflake troubleshooting team has asked us to provide client side logs to them about a Production issue. Is there any way this can be quickly implemented, as it is such a small piece of code, and it is clearly a bug with no other work around?

@sfc-gh-dszmolka
Copy link
Contributor

I believe we do mention at the README here that due to the nature of how this is an open-source github repo with entirely different (scale of) resources put behind the support, if you have major, production issue then you would be better off filing a Support case with us. As it has procedures, SLA's, and everything else which this interface doesn't.

Did someone ask you after filing an official Support case, to come here instead and file an Issue? That sounds weird and I would like to let me know about your case number if this indeed happened, because it should not.

The official Support case also lets you select a severity, which matches the business impact the particular gap is causing you. That is also not possible here. A very high severity Case should get to the proper team very quickly so I'm mildly confused really, how you ended up here if you had a case with us.

@Coder3333
Copy link
Contributor Author

I believe we do mention at the README here that due to the nature of how this is an open-source github repo with entirely different (scale of) resources put behind the support, if you have major, production issue then you would be better off filing a Support case with us. As it has procedures, SLA's, and everything else which this interface doesn't.
...

@sfc-gh-dszmolka , we filed a support case. The support engineer told us they would not proceed without client side logs, we then discovered that we cannot collect client side logs due to this bug in the .Net Connector. My next step will be to report the PR to the support engineer, if you are telling me they have more ability to deploy a new version of the .Net Connector than the team that manages the git repo.

@sfc-gh-dszmolka
Copy link
Contributor

Thanks for the clarification! No, Support has absolutely no ability to verify and deploy the PRs which the community submits (and we greatly value those PR's, let me quickly note here!)

It always needs the code owner to do so, the driver dev team. As a side action, I pinged them internally to look, so hopefully someone can soon. In the meantime if you already have an ongoing case with us, which is hopefully some high priority since the impact to your company is high, please do tell the PR to the support engineer.

With this particular Issue here, i'll also keep updated with the progress from the PR .

@sfc-gh-dszmolka
Copy link
Contributor

While the team gets to reviewing the PR, i just wanted to ensure you're already aware of https://community.snowflake.com/s/article/How-to-generate-log-file-on-Snowflake-connectors , which can provide some pointers to how to enable logging for this driver even without EasyLogging (which is a relatively newer feature, and which your PR seems to be targeting)

@Coder3333
Copy link
Contributor Author

While the team gets to reviewing the PR, i just wanted to ensure you're already aware of https://community.snowflake.com/s/article/How-to-generate-log-file-on-Snowflake-connectors , which can provide some pointers to how to enable logging for this driver even without EasyLogging (which is a relatively newer feature, and which your PR seems to be targeting)

@sfc-gh-dszmolka , Thank you for pointing that out. I will try to configure log4net without EasyLogging. All of the current documentation emphasizes EasyLogging to the point that it looks like it is mandatory.

@sfc-gh-dszmolka sfc-gh-dszmolka added the status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. label Jan 29, 2025
@sfc-gh-dszmolka
Copy link
Contributor

seems to be addressed in #1087 and is now awaiting release - thank you for your contribution!

@sfc-gh-dszmolka
Copy link
Contributor

change released in .NET driver version 4.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Development

No branches or pull requests

3 participants