Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add of class1 and class2 options in the annotateDiffreport function #73

Open
a-velt opened this issue Sep 23, 2021 · 2 comments
Open

Add of class1 and class2 options in the annotateDiffreport function #73

a-velt opened this issue Sep 23, 2021 · 2 comments

Comments

@a-velt
Copy link

a-velt commented Sep 23, 2021

Hello,

Just a note about the annotateDiffreport() function. It seems that it does not allow us to choose the two classes we want to compare, and by default, classes 1 and 2 are chosen.

However, in the diffreport() function, it is possible to give these classes as arguments of the function (class1 and class2), but these two arguments are not offered in the annotateDiffreport() function. Is there a reason for this?

I created a annotateDiffreport_classes() function, which take these two additionnal arguments and pass them to the diffreport() function. It seems that this works fine.

Have a nice day,
Amandine

@korseby
Copy link
Collaborator

korseby commented Sep 26, 2021

Hi Amandine,

This issue is perfectly reasonable. Unless the additional arguments do not break anything, I vote for changing annotateDiffreport and updating the man page to that function accordingly. What does @sneumann think about it?

I don't see a pull request to review the changes. Can you provide one?

Best wishes, *Kristian

@a-velt
Copy link
Author

a-velt commented Sep 27, 2021

Thank you for your reply ! I just made a pull request.

Best
Amandine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants