You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
in a call today related to #38@yguitton mentioned he had discovered that annotateDiffreport
seems to not propagate the calcIso=TRUE parameter down to the groupCorr()
Indeed I get identical results:
library(CAMERA)
library(faahKO)
xs.grp <- group(faahko)
xs.fill <- fillPeaks(xs.grp)
diffreportFALSE <- annotateDiffreport(xs.fill, calcIso = FALSE, calcCiS = TRUE, calcCaS = FALSE)
diffreportTRUE <- annotateDiffreport(xs.fill, calcIso = TRUE, calcCiS = TRUE, calcCaS = FALSE)
## Test if that parameter makes any difference:
diffreportTRUE[,"pcgroup"] == diffreportFALSE[,"pcgroup"]
where I'd expect this should be different. A PR could include that as unit test.
Yours,
Steffen
The text was updated successfully, but these errors were encountered:
Hi,
in a call today related to #38 @yguitton mentioned he had discovered that
annotateDiffreport
seems to not propagate the
calcIso=TRUE
parameter down to thegroupCorr()
Indeed I get identical results:
where I'd expect this should be different. A PR could include that as unit test.
Yours,
Steffen
The text was updated successfully, but these errors were encountered: