Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calcIso in annotaeDiffreport not propagated down to groupCorr #65

Closed
sneumann opened this issue Feb 19, 2021 · 1 comment · Fixed by #66
Closed

calcIso in annotaeDiffreport not propagated down to groupCorr #65

sneumann opened this issue Feb 19, 2021 · 1 comment · Fixed by #66

Comments

@sneumann
Copy link
Owner

Hi,
in a call today related to #38 @yguitton mentioned he had discovered that annotateDiffreport
seems to not propagate the calcIso=TRUE parameter down to the groupCorr()

Indeed I get identical results:

library(CAMERA)
library(faahKO)
xs.grp     <- group(faahko)
xs.fill    <- fillPeaks(xs.grp)

diffreportFALSE <- annotateDiffreport(xs.fill, calcIso = FALSE, calcCiS = TRUE, calcCaS = FALSE)
diffreportTRUE  <- annotateDiffreport(xs.fill, calcIso = TRUE,  calcCiS = TRUE, calcCaS = FALSE)

## Test if that parameter makes any difference:
diffreportTRUE[,"pcgroup"] == diffreportFALSE[,"pcgroup"]

where I'd expect this should be different. A PR could include that as unit test.
Yours,
Steffen

@sneumann
Copy link
Owner Author

I can confirm the two diffreports are different when adding calcIso=calcIso in
https://github.com/sneumann/CAMERA/blob/master/R/xsAnnotate.R#L1162
Yours, Steffen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant