Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No option to change intval (intensity type) in findAdducts function #39

Open
sunil20dhakad opened this issue Jul 23, 2019 · 2 comments
Open

No option to change intval (intensity type) in findAdducts function #39

sunil20dhakad opened this issue Jul 23, 2019 · 2 comments

Comments

@sunil20dhakad
Copy link

sunil20dhakad commented Jul 23, 2019 •
edited
Loading

There is no option to change intval option in findAdducts() function. Currently, it has a fixed value ("maxo").

It is written in the code as:

#TODO: Change intensity choosing?
intval <- "maxo"; #max. intensity
@sneumann
Copy link
Owner

Thanks for spotting this. Would you be willing to create a pull request ?
I would expect this to be hard-coded in other places as well.
Yours, Steffen

@stanstrup
Copy link
Contributor

ad "other places": It was fixed in groupcorr a few years back #15.

@sunil20dhakad sunil20dhakad mentioned this issue Jul 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sneumann @stanstrup @sunil20dhakad