-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liblouis table for Dutch without capsign #9
Comments
In addition to capsign, the begcaps, endcaps and emphasis signs should also be suppressed. |
No you can't unset. Just move all the things you don't want to a separate table, include it in the main table, and don't include it in the alternative table. |
This implies that for the stock nl-NL table we'll have to split off caps and emphasis signs into their own file. Is that acceptable? I'm reluctant to split off the entire nl-NL table into a package specific to Dedicon because of the extra maintenance that will cause. IMO standard printing should be done with the standard (stock) table, and only exceptions should be split off into a different package. |
Sounds acceptable to me. Splitting the table into modules doesn't affect the behavior of the "root" table. I think we can even include this table without capsign in the official liblouis distribution, in addition to the main table. Sounds like something generally useful. |
Then we'd have 3 new tables: |
Sounds good. So we'll also rename to g0.utb? For 3rd parties using liblouis it's probably best to do all the file renames at once so they don't have to update their products all the time. |
I have already renamed to g0. See commit c224f06. |
I wanted an ordered list of possible solutions to this problem, so here goes:
My preferred solution is 5. |
Thanks for the analysis. Some remarks:
I like to think of liblouis tables (or possibly the combination table/mode) as complete and portable representations of a braille code. So I like to avoid pre-processing as much as possible. That brings me to my preferred solution 3 (or 1). |
I feel (1) is the cleanest solution because (2) is "semantically unpleasant", (4) isn't really a solution in and of itself, and (5) alters input text which is the same problem as (2). My second preferred option is (3), but maybe the concept of a "table without caps" isn't very useful to most people. Plus, (1) should work for any table. I just hope it won't get too hacky dealing with all these different opcodes. Regardless of how we implement this, I was wondering how/where to configure this. Could be a configuration parameter or (more flexible) a braille CSS element. I.e. on the cover of children's books we use caps but inside we don't, so some granularity would be good. Is this integrated yet/should I look for a sample document (which also uses double line-spacing)? |
OK so tests are likely failing due to @MikeGray-APH's patches. That having been said, I still really like solution (1) so am going to do at least a casual code review to see how hard this would be to do. |
I was going to ask you about the configuration granularity. First I thought it was going to be a top-level setting, i.e. either caps everywhere or caps nowhere. In that case the most appropriate solution would have been to add e.g. Things change slightly if configuration is requirement on a finer level, because then we need Braille CSS. The sections where no caps should be used would get a All options are still open in both cases, but this background info might change your view a bit. Go ahead if you want to explore solution 1. Remember that we can just do what's easiest to implement, and record issues for things that can possibly be improved later. |
I think Is this handled in Java or in XML/XSLT? A simple We currently have (3) implemented in dkager_dutch, so I'm tempted to stick with that. However:
Thoughts? I can update the CSS spec and if the implementation is mostly in Java I also look at that. Merging the tables back together isn't a big deal either so that shouldn't be a reason to hold off on implementing (5). |
OK, do what you think is the right thing to do. The I will take care of updating the Braille CSS spec, I have been preparing to do that anyway. The text-transform property is already largely implemented. See also braillespecs/braille-css#12 and daisy/pipeline-mod-braille#23. |
Seems that joining the nocaps tables back together was a good idea as now Mike's patches don't cause issues anymore. I can use that branch for further development, but we'll have to decide if/when this makes its way into liblouis (upstream) and when this will be used for pipeline-mod-braille. I'll spend some time on it today unless something else comes up. |
This is now implemented in liblouis-core (aef6204). Can we tick this issue off, or is there more to do? |
Yes, this is done. Thanks Davy. Will close as soon as I merge the branch. |
No description provided.
The text was updated successfully, but these errors were encountered: