This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Time off request API methods #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olicies method also
|
Currently adding test cases to support the new API methods 👍 |
horida
reviewed
Jul 6, 2020
Comment on lines
+260
to
+266
| if request_data.get('notes') and len(request_data.get('notes')) > 0: | ||
| notes = '' | ||
| for n in request_data['notes']: | ||
| f = n.get('type', 'employee') | ||
| t = n.get('text', '') | ||
| notes += '\n\t\t<note from="{0}">{1}</note>'.format(f, t) | ||
| xml += '\n\t<notes>{0}\n\t</notes>'.format(notes) |
There was a problem hiding this comment.
Suggested change
| if request_data.get('notes') and len(request_data.get('notes')) > 0: | |
| notes = '' | |
| for n in request_data['notes']: | |
| f = n.get('type', 'employee') | |
| t = n.get('text', '') | |
| notes += '\n\t\t<note from="{0}">{1}</note>'.format(f, t) | |
| xml += '\n\t<notes>{0}\n\t</notes>'.format(notes) | |
| notes = '' | |
| for note in request_data.get('notes', []): | |
| f = note.get('type', 'employee') | |
| t = note.get('text', '') | |
| notes += '\n\t\t<note from="{0}">{1}</note>'.format(f, t) | |
| xml += '\n\t<notes>{0}\n\t</notes>'.format(notes) |
Same pattern can be used for dates 😉
horida
reviewed
Jul 6, 2020
| params['end'] = end_date | ||
| if status: | ||
| params['status'] = status | ||
| # Must set dates or request errors 400 Bad Request |
There was a problem hiding this comment.
BambooHR's API says it is optional. 🤔
https://www.bamboohr.com/api/documentation/time_off.php#getRequest
start (optional) - Only show time off that occurs on/after the specified start date.
end (optional) - Only show time off that occurs on/before the specified end date.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan to use these API's in the future, thanks for the project so far 👍
Add API methods for:
Fix:
start+endparams in get requestAdd utility method for: