Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit query construction #130

Closed
dogversioning opened this issue Oct 17, 2024 · 1 comment
Closed

Revisit query construction #130

dogversioning opened this issue Oct 17, 2024 · 1 comment

Comments

@dogversioning
Copy link
Contributor

In some places (notably the chart data endpoint), we're constructing SQL via string concatenation, which is less than ideal. We should do the following:

  • See if there's a pre-existing layer that adds jinja support for lambdas
    • If so, flip to using templates
    • If not, be more careful about quoting parameters
@dogversioning
Copy link
Contributor Author

addressed via #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant