Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Columns don't line up with headers in output. #244

Closed
vext01 opened this issue Jul 31, 2024 · 6 comments · Fixed by #246
Closed

Columns don't line up with headers in output. #244

vext01 opened this issue Jul 31, 2024 · 6 comments · Fixed by #246
Labels
Bug

Comments

@vext01
Copy link
Contributor

vext01 commented Jul 31, 2024

When the experiment finishes, a table is printed like this:

-----------------------------------------------------------------------------------------------
  Benchmark    Executor   Suite    Extra   Core      Size   Var   #Samples   Mean (ms)
-----------------------------------------------------------------------------------------------
  Json         Lua        awfy       100   default           30                     30   1150
  Richards     Lua        awfy       100   default           30                     30   4523
  Storage      Lua        awfy      1000   default           30                     30   2163
  Permute      Lua        awfy      1000   default           30                     30   1277
  Queens       Lua        awfy      1000   default           30                     30    856
  DeltaBlue    Lua        awfy     12000   default           30                     30   1196
  Havlak       Lua        awfy      1500   default           30                     30   7009
  Bounce       Lua        awfy      1500   default           30                     30   1412
  List         Lua        awfy      1500   default           30                     30    925
  CD           Lua        awfy       250   default           30                     30   3079
  NBody        Lua        awfy    250000   default           30                     30   1038
  Sieve        Lua        awfy      3000   default           30                     30   1061
  Mandelbrot   Lua        awfy       500   default           30                     30    372
  Towers       Lua        awfy       600   default           30                     30   1367
-----------------------------------------------------------------------------------------------

The output is quite hard to read because the data doesn't line up with the headings.

I don't know if prettytable would help. I've used it a bit for this kind of thing and found that it works pretty (no pun intended) well.

Cheers
@smarr smarr mentioned this issue Jul 31, 2024
Merged
@smarr smarr added the Bug label Jul 31, 2024
@smarr
Copy link
Owner

smarr commented Jul 31, 2024 •
edited
Loading

Does this do the trick? #246

ReBench uses this library for the table formatting: https://humanfriendly.readthedocs.io/en/latest/api.html?highlight=format_pretty_table#humanfriendly.tables.format_pretty_table

@vext01
Copy link
Contributor Author

vext01 commented Jul 31, 2024

Looks much better!

--------------------------------------------------------------------------------------------------
  Benchmark    Executor   Suite    Extra   Core      Size   Var   Machine   #Samples   Mean (ms)
--------------------------------------------------------------------------------------------------
  Richards     Lua        awfy       100   default                                 1        4362
  Json         Lua        awfy       100   default                                 1        1161
  Queens       Lua        awfy      1000   default                                 1         820
  Storage      Lua        awfy      1000   default                                 1        2117
  Permute      Lua        awfy      1000   default                                 1        1301
  DeltaBlue    Lua        awfy     12000   default                                 1         905
  Bounce       Lua        awfy      1500   default                                 1        1573
  Havlak       Lua        awfy      1500   default                                 1        6731
  List         Lua        awfy      1500   default                                 1        1001
  CD           Lua        awfy       250   default                                 1        3062
  NBody        Lua        awfy    250000   default                                 1         994
  Sieve        Lua        awfy      3000   default                                 1        1246
  Mandelbrot   Lua        awfy       500   default                                 1         371
  Towers       Lua        awfy       600   default                                 1        1247
--------------------------------------------------------------------------------------------------

Cheers :)

@smarr
Copy link
Owner

smarr commented Jul 31, 2024

Looking at your CI output here: https://ci.soft-dev.org/#/builders/3/builds/307
I am not sure you control the source of you build system, but if you do, you'd want to change the css style from:

.logline>span {
    white-space: nowrap;
}

.logline>span {
    white-space: pre;
}

This should preserver the whitespace.
See also: https://developer.mozilla.org/en-US/docs/Web/CSS/white-space#values

@vext01
Copy link
Contributor Author

vext01 commented Jul 31, 2024

It's buildbot doing that. I'm not too worried, since you can click "raw" and it just gives you plain text with correct formatting.

@smarr smarr linked a pull request Jul 31, 2024 that will close this issue
Added missing machine column heading for summary table #246
Merged
@smarr
Copy link
Owner

smarr commented Jul 31, 2024

Closing with #246 being merged. Thanks!

@smarr smarr closed this as completed Jul 31, 2024
@vext01
Copy link
Contributor Author

vext01 commented Jul 31, 2024

Cheers Stefan!

@vext01 vext01 mentioned this issue Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added missing machine column heading for summary table smarr/ReBench
2 participants
@smarr @vext01