Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with grails 2.4 #61

Open
bdbull opened this issue Jun 2, 2014 · 4 comments
Open

Incompatible with grails 2.4 #61

bdbull opened this issue Jun 2, 2014 · 4 comments

Comments

@bdbull
Copy link

bdbull commented Jun 2, 2014

This is incompatible with grails 2.4 due to the CongurationHolder class being removed. See the "Static Holder Classes" section at http://grails.org/doc/2.4.0.M1/guide/upgradingFrom23.html.

@tiagopomponet
Copy link

The grails documentation shows that code that use ConfigurationHolder class needs to be updated with "grails.util.Holders".
(see: Static Holder Classes - http://grails.org/doc/2.4.x/guide/upgradingFrom23.html).

In that case the grails-events-push plugin also needs to be up-to-date. I believe that just by adding:
"import grails.util.Holders"
instead of
"import org.codehaus.groovy.grails.commons.ConfigurationHolder" at "/events-push-1.0.M7/scripts/_Events.groovy" (line 20, column 1) would solve the problem.

@jfarcand
Copy link
Contributor

jfarcand commented Jun 2, 2014

@tiagopomponet pull request welcomed!!

yellowsnow added a commit to yellowsnow/grails-events-push that referenced this issue Jun 9, 2014
For Grails 2.4.x compatibility
jfarcand added a commit that referenced this issue Jun 25, 2014
@bdbull
Copy link
Author

bdbull commented Oct 31, 2014

Can someone push this to the grails plugin repository?

@vtr88
Copy link

vtr88 commented Nov 12, 2014

Still waiting for the grails repo to be updated with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants