Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trayicon: set XAyatanaLabel attribute for "Show next break time in tray icon" #646

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

deltragon
Copy link
Collaborator

Fixes #643

This a non-standard attribute that is not supported by many desktops, e.g. KDE and snixembed.
However, this also did not work with libappindicator on KDE before.

This should fix the regression in #643 for all desktops that support both StatusNotifierItem and the non-standard XAyatanaLabel property, notably GNOME with the AppIndicator and KStatusNotifierItem Support extension.

…ay icon"

Fixes slgobinath#643

this a non-standard attribute that is not supported by many desktops, e.g. KDE and snixembed
however, this also did not work with libappindicator on KDE before
@deltragon
Copy link
Collaborator Author

I have not tested this on GNOME yet, only on KDE (where it continues to not show the time in the tray icon).
I will try and test this on GNOME the next few days.

@AdamPS AdamPS marked this pull request as ready for review September 18, 2024 08:47
@AdamPS AdamPS self-requested a review September 18, 2024 08:48
Copy link
Collaborator

@AdamPS AdamPS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested on Gnome

@archisman-panigrahi
Copy link
Collaborator

archisman-panigrahi commented Sep 21, 2024

It shows up prominently in GNOME

image

Shows up as a tooltip in KDE6 (no change before and after this PR)

image

Also works in XFCE.

However, it does not work with snixembed in LXDE

@archisman-panigrahi
Copy link
Collaborator

Does not work with snixembed in MATE Screenshot_20240921-190403.jpg

@archisman-panigrahi
Copy link
Collaborator

We have to make some decision on whether we want to support this feature on snixembed. Otherwise, I approve this PR.

@archisman-panigrahi
Copy link
Collaborator

Given it works in some form in GNOME, KDE, XFCE and Cinnamon (image attached), I am in favor of merging this.

image

@deltragon If you think this can be somehow made to work with snixembed please let us know, otherwise, I will just merge it as it is.

Thank you all!

@archisman-panigrahi archisman-panigrahi merged commit 628abe2 into slgobinath:master Sep 23, 2024
1 check passed
@deltragon deltragon deleted the xayatanalabel branch September 23, 2024 17:57
@deltragon
Copy link
Collaborator Author

Thanks!
The fact that it doesn't change the tooltip at all with snixembed is surprising - in theory, it does have support for the tooltip (and also shows the original tooltip). So this might just be an issue of it not realising the tooltip was updated.
I can look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Show next break time in tray icon" isn't working
3 participants