-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trayicon: set XAyatanaLabel attribute for "Show next break time in tray icon" #646
trayicon: set XAyatanaLabel attribute for "Show next break time in tray icon" #646
Conversation
…ay icon" Fixes slgobinath#643 this a non-standard attribute that is not supported by many desktops, e.g. KDE and snixembed however, this also did not work with libappindicator on KDE before
I have not tested this on GNOME yet, only on KDE (where it continues to not show the time in the tray icon). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and tested on Gnome
We have to make some decision on whether we want to support this feature on snixembed. Otherwise, I approve this PR. |
Given it works in some form in GNOME, KDE, XFCE and Cinnamon (image attached), I am in favor of merging this. @deltragon If you think this can be somehow made to work with snixembed please let us know, otherwise, I will just merge it as it is. Thank you all! |
Thanks! |
Fixes #643
This a non-standard attribute that is not supported by many desktops, e.g. KDE and snixembed.
However, this also did not work with libappindicator on KDE before.
This should fix the regression in #643 for all desktops that support both StatusNotifierItem and the non-standard XAyatanaLabel property, notably GNOME with the AppIndicator and KStatusNotifierItem Support extension.