Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make config and stylesheet files non-executable #634

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

terop
Copy link
Contributor

@terop terop commented Aug 12, 2024

There is no need to have the executable bit on for the config and stylesheet files as they are not run by themselves.

There is no need to have the executable bit on for the config and
stylesheet files as they are not run by themselves.
Copy link
Collaborator

@deltragon deltragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Maybe we should review the permissions there generally, I'm not sure if they need to be world-writable - but that can happen in a separate PR.

@deltragon deltragon merged commit 9a8891d into slgobinath:master Aug 12, 2024
1 check passed
@terop terop deleted the non_executable_config branch August 12, 2024 16:46
@terop
Copy link
Contributor Author

terop commented Aug 12, 2024

I did notice the "other" group permissions but I wasn't sure what would be the appropriate value so did not change it. If we agree on the value(s) I can create a new PR to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants