Add dbus-python to required dependencies #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SafeEyes does not start without dbus-python and therefore it is added to required dependencies in setup.py.
|
Is there some particular reason which I am missing why dbus-python is not included in the required dependencies? |
|
(Note that in #558, I am proposing to drop dbus-python altogether. Until then, I agree that this PR seems reasonable.) |
nifadyev
approved these changes
Jan 13, 2024
There was a problem hiding this comment.
LGTM, Thanks for your effort @terop
@deltragon , totally agree with your proposal, dbus should be removed, but it's out of scope of this PR
deltragon
approved these changes
Jan 24, 2024
|
@deltragon @nifadyev could this PR be merged if the changes are okay? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SafeEyes does not start without dbus-python and therefore it is added to required dependencies in setup.py.