Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Show next break time in tray icon" isn't working #643

Closed
AdamPS opened this issue Aug 26, 2024 · 11 comments · Fixed by #646
Closed

"Show next break time in tray icon" isn't working #643

AdamPS opened this issue Aug 26, 2024 · 11 comments · Fixed by #646
Labels

Comments

@AdamPS
Copy link
Collaborator

AdamPS commented Aug 26, 2024

Describe the bug
After a recent upgrade, the setting "Show next break time in tray icon" isn't working

To Reproduce
Click on settings, select plugins, open Tray Icon settings and enable "Show next break time in tray icon". Nothing happens, I don't see the time.

Expected behavior
I see the time adjacent to the tray icon.

Desktop (please complete the following information):

  • Ubuntu 24.04
  • GNOME
  • Version 2.2.2

Debug Log
Run the Safe Eyes using safeeyes --debug command attach the ~/safeeyes.log` file.

Screenshots
If applicable, add screenshots to help explain your problem.

@AdamPS AdamPS added the bug label Aug 26, 2024
Repository owner deleted a comment Aug 26, 2024
Repository owner deleted a comment Aug 26, 2024
Repository owner deleted a comment from mohamed-elsankary Aug 26, 2024
Repository owner deleted a comment Aug 26, 2024
@AdamPS
Copy link
Collaborator Author

AdamPS commented Sep 10, 2024

I believe B was caused by #558
A and C are long-time bugs

@AdamPS
Copy link
Collaborator Author

AdamPS commented Sep 10, 2024

The current code tries to put the time in a tooltip, but that's not really right. We don't want to have to hover to see the time. Anyway tooltips seem to be unsupported in AppIndicator.

The previous code used indicator.set_label()

However StatusNotifierItem seems to be missing a function for label.

@AdamPS AdamPS changed the title Problems with tray icon plugin "Show next break time in tray icon" isn't working Sep 10, 2024
@AdamPS
Copy link
Collaborator Author

AdamPS commented Sep 10, 2024

Please can the main contributors for the issue that caused this regression join the discussion here?
@archisman-panigrahi @deltragon

deltragon added a commit to deltragon/SafeEyes that referenced this issue Sep 12, 2024
…ay icon"

Fixes slgobinath#643

this a non-standard attribute that is not supported by many desktops, e.g. KDE and snixembed
however, this also did not work with libappindicator on KDE before
@deltragon
Copy link
Collaborator

@AdamPS I have a PR up that should hopefully fix this: #646

@deltragon
Copy link
Collaborator

Regarding C - at least on KDE Plasma, there's a method to integrating xdg-activation into the tray icon ("ProvideXdgActivationToken"). Looking at this, it seems the GNOME extension supports it too.
IIUC, this maps to the GtkWindow.set_startup_id method, which at least for GTK4 supports xdg-activation.
I'll look into it, but it might make sense to track in a different issue.

@AdamPS
Copy link
Collaborator Author

AdamPS commented Sep 18, 2024

Great thanks. I confirm that the PR works on Gnome.

@AdamPS
Copy link
Collaborator Author

AdamPS commented Sep 18, 2024

Regarding C - at least on KDE Plasma, there's a method to integrating xdg-activation into the tray icon ("ProvideXdgActivationToken"). Looking at this, it seems the GNOME extension supports it too. IIUC, this maps to the GtkWindow.set_startup_id method, which at least for GTK4 supports xdg-activation. I'll look into it, but it might make sense to track in a different issue.

I raised #649

@archisman-panigrahi
Copy link
Collaborator

archisman-panigrahi commented Sep 18, 2024

Sorry about my silence in the past several weeks. I can test the PRs tonight.
@deltragon Can you please suggest the order in which I can test/merge the existing PRs?

@deltragon
Copy link
Collaborator

@archisman-panigrahi #646 is probably the highest priority.

@archisman-panigrahi
Copy link
Collaborator

archisman-panigrahi commented Sep 22, 2024

@AdamPS Can you please edit A and C out of this? I was initially super confused about whether #646 is about A and C or not.

Please create a separate issue for A.

@AdamPS
Copy link
Collaborator Author

AdamPS commented Oct 2, 2024

Great thanks for the fix.

Please create a separate issue for A.

#654

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants