Re-org structure of inheritence #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstelter-slac
force-pushed
the
new_psana_base
branch
4 times, most recently
from
069b967 to
b02e721
Compare
nstelter-slac
force-pushed
the
new_psana_base
branch
from
b02e721 to
38623ac
Compare
Idea is to use psanaBase for handling 1 vs 2 differences, and move all shared vars and funcs into suiteBase
nstelter-slac
force-pushed
the
new_psana_base
branch
from
ea08377 to
45d0733
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly re-orgs where functions and variables live
-Idea is to add psanaBase.py, which basically handles all the 1 vs 2 function differences.
-and then move everything else to suiteBase.py