Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastify listening interfaces should be configurable #7

Open
rogama25 opened this issue Nov 15, 2024 · 1 comment
Open

Fastify listening interfaces should be configurable #7

rogama25 opened this issue Nov 15, 2024 · 1 comment

Comments

@rogama25
Copy link

I'm currently deploying a labeler inside a Docker container, and this library does not set the internal fastify instance to listen on all interfaces, so I had to set it up like this:
labelerServer.app.listen({port, host: "::"}, callback)

It feels quite wrong having to access the internal fastify object instead of passing it just the same as the port

@rogama25 rogama25 changed the title Fastify interfaces should be configurable Fastify listening interfaces should be configurable Nov 15, 2024
@futurGH
Copy link
Contributor

futurGH commented Nov 20, 2024

This is fixed in 29794f5, just need to publish a release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants