From f0bb6bad945d21a3c79c8f56996699ae6fe1c322 Mon Sep 17 00:00:00 2001 From: Tian Xia Date: Thu, 18 Jan 2024 09:29:37 +0800 Subject: [PATCH] [SkyServe] Check positive for `target_qps_per_replica` (#2995) fix --- sky/serve/service_spec.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sky/serve/service_spec.py b/sky/serve/service_spec.py index b565d8c5171..dca0cf3ef62 100644 --- a/sky/serve/service_spec.py +++ b/sky/serve/service_spec.py @@ -41,6 +41,10 @@ def __init__( raise ValueError( 'max_replicas must be greater than or equal to min_replicas' ) + if target_qps_per_replica is not None and target_qps_per_replica <= 0: + with ux_utils.print_exception_no_traceback(): + raise ValueError( + 'target_qps_per_replica must be greater than 0') if not readiness_path.startswith('/'): with ux_utils.print_exception_no_traceback(): raise ValueError('readiness_path must start with a slash (/). '