Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui] Improve result highlight in Usage and Search dialogs #2009

Open
skylot opened this issue Sep 15, 2023 · 2 comments
Open

[gui] Improve result highlight in Usage and Search dialogs #2009

skylot opened this issue Sep 15, 2023 · 2 comments
Labels
enhancement GUI Issues in jadx-gui module
Milestone

Comments

@skylot
Copy link
Owner

skylot commented Sep 15, 2023

Now for highlight search result in Usage dialog used text search in code line, but jadx knows exact node place and should use that info to correctly highlight code.
Same approach should be used in Search dialog for Class/Method/Field nodes search.

This issue created from discussion started in #2006.

@skylot skylot added new feature enhancement GUI Issues in jadx-gui module and removed new feature labels Sep 15, 2023
@skylot skylot added this to the TBD milestone Sep 15, 2023
@MrIkso

This comment was marked as off-topic.

@skylot
Copy link
Owner Author

skylot commented Dec 25, 2024

@MrIkso not sure why you decided to redone UI, because this issue is more about highlighting in code view for usage dialog and only partially in search dialog. And #2373 is just fixing resource name.

Anyway, main focus in table version of UI was on code view, because often class names are obfuscated and don't help in understanding code logic. So I don't think such rework is really needed, I suggest opening a draft PR for this change, maybe someone else will share another opinion or suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement GUI Issues in jadx-gui module
Projects
None yet
Development

No branches or pull requests

2 participants