Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

已开始用go写skr-shop,发现问题 #28

Open
xushuhui opened this issue Jul 7, 2020 · 10 comments
Open

已开始用go写skr-shop,发现问题 #28

xushuhui opened this issue Jul 7, 2020 · 10 comments

Comments

@xushuhui
Copy link
Contributor

xushuhui commented Jul 7, 2020

我已经开始用go写skr-shop,先从后台cms写起,但是我发现手册中数据库表有些错误,可以发pr吗?如果可以,流程是怎么样的?
地址:https://github.com/xushuhui/skrshop-api
感谢设计出skr-shop的作者们

@TIGERB
Copy link
Member

TIGERB commented Jul 7, 2020

欢迎pr~

@TIGERB
Copy link
Member

TIGERB commented Jul 7, 2020

流程不复杂:
我们对pr的内容,进行核对、讨论、(修正)、合并(或者关闭)

感谢~

@xushuhui
Copy link
Contributor Author

xushuhui commented Jul 8, 2020

为什么sql中的create_at和update_at都是int类型,而不使用数据库通过CURRENT_TIMESTAMP,CURRENT_TIMESTAMP ON UPDATE 自动维护这两个字段?

@TIGERB
Copy link
Member

TIGERB commented Jul 8, 2020

  1. timestamp 貌似mysql之前版本或者现在版本 只能到 2038年
  2. timestamp好像存的是 字符串,对海外的站点应用是不是有时区问题

@xushuhui
Copy link
Contributor Author

xushuhui commented Jul 9, 2020

在一些表中的status字段默认0禁用,比如product_brand,而运营人员在后台批量添加的时候添加完后还得一个个点击启用按钮,把状态改成1启用,这样会不会比较麻烦,默认禁用的原因是什么?为了体验考虑?添加的时候可能出现错误,禁用就不会展示给用户端?

@TIGERB
Copy link
Member

TIGERB commented Jul 9, 2020

首先,最重要是为了统一所有表里status字段的含义、定义。

其次,不考虑status字段具体在哪张表,默认0:disable的状态对于线上一定是最安全,对于重要的status变更一定要经过严格的审批流,防止一些严重的线上运营事故。

结论:表product_brand里的status字段默认值是0:disable。

@astraw99
Copy link
Contributor

astraw99 commented Jul 10, 2020 via email

@astraw99
Copy link
Contributor

astraw99 commented Jul 10, 2020 via email

@xushuhui
Copy link
Contributor Author

希望增加整个微服务的目录介绍,比如分几个服务,每个服务哪些目录,为什么这么设计等。
对大部分小公司开发者来说,用户量和并发比较小,没什么机会接触到微服务架构,所以设计还是按单体模式。
有这部分介绍就能从整体角度看整个项目,不局限某个业务功能,谢谢了。

@TIGERB
Copy link
Member

TIGERB commented Jul 15, 2020

好的哈

可以先看看这张图

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants