Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23360] Fix bus transport loading incorrect icon #188

Merged
merged 1 commit into from
Feb 12, 2025
Merged

[23360] Fix bus transport loading incorrect icon #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...KitAndroidUI/src/main/java/com/skedgo/tripkit/ui/core/binding/ImageViewBindingAdapters.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@ import com.skedgo.tripkit.common.model.TransportMode.Companion.getLocalIconResId
import com.skedgo.tripkit.common.util.TransportModeUtils.getIconUrlForId
import com.skedgo.tripkit.common.util.TransportModeUtils.getIconUrlForModeInfo
import com.skedgo.tripkit.routing.ModeInfo
import com.skedgo.tripkit.ui.GlideApp
import com.skedgo.tripkit.ui.R
import com.skedgo.tripkit.ui.TripKitUI
import timber.log.Timber

object ImageViewBindingAdapters {
@JvmStatic
Expand Down Expand Up @@ -103,16 +105,20 @@ object ImageViewBindingAdapters {
@JvmStatic
@BindingAdapter("modeIconId")
fun bindModeIconId(view: ImageView, modeIconId: String?) {
Timber.tag("ImageViewBindingAdapters: modeIconId").i("$modeIconId")
val resId = getLocalIconResId(modeIconId)
if (resId == 0) {
if (!TextUtils.isEmpty(modeIconId)) {
val url = getIconUrlForId(view.resources, modeIconId)
TripKitUI.getInstance().picasso()
Timber.tag("ImageViewBindingAdapters: modeIconId").i("loading icon from: $url")
GlideApp.with(view.context)
.load(url)
.skipMemoryCache(true)
.placeholder(R.drawable.ic_car_ride_share)
.error(R.drawable.ic_car_ride_share)
.into(view)
} else {
Timber.tag("ImageViewBindingAdapters: modeIconId").i("loading icon from local")
view.setImageResource(R.drawable.ic_car_ride_share)
}
}
Expand Down